Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate_t4_dataset): add nbr_samples checker, sample token checker #127

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Jul 9, 2024

Description

How to review

How to test

test data

test command

python -m perception_dataset.validate_t4_dataset --root-path PATH_TO_DATASET

Reference

Notes for reviewer

@miursh miursh requested a review from kminoda July 9, 2024 03:28
@miursh miursh changed the title add nbr_samples checker, sample token checker feat(validate_t4_dataset): add nbr_samples checker, sample token checker Jul 9, 2024
Copy link
Collaborator

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 🙏

perception_dataset/t4_dataset/format_validator.py Outdated Show resolved Hide resolved
perception_dataset/t4_dataset/format_validator.py Outdated Show resolved Hide resolved
@kminoda
Copy link
Collaborator

kminoda commented Jul 23, 2024

Also the test is failing 😢

@miursh miursh marked this pull request as draft August 6, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants