Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(velodyne): add node name to diag name of hesai hw_monitor #281

Merged

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Feb 25, 2025

PR Type

  • Improvement

Related Links

This applies the same changes to vleodyne as #217

Description

Added namespace so that velodyne_hw_monitor can diag each LiDAR.

Previously, when multiple Velodyne LiDAR drivers are running, the diagnostics for all LiDARs are labeled as velodyne_ros_wrapper_node, making it impossible to distinguish between them.

With this fix, each LiDAR's namespace is added to the diagnostics, allowing them to be properly distinguished.
For example, the diagnostics now appear as follows:

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi KYabuuchi marked this pull request as ready for review February 25, 2025 10:31
@KYabuuchi KYabuuchi requested a review from mojomex February 25, 2025 10:31
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.47%. Comparing base (1128658) to head (3d2eb28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   29.28%   26.47%   -2.81%     
==========================================
  Files         112      112              
  Lines        9733     9526     -207     
  Branches     3252     2122    -1130     
==========================================
- Hits         2850     2522     -328     
- Misses       6359     6580     +221     
+ Partials      524      424     -100     
Flag Coverage Δ
differential 26.47% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 18.37% <ø> (-31.87%) ⬇️
Hesai 29.69% <ø> (-0.72%) ⬇️
Velodyne 37.25% <0.00%> (+0.06%) ⬆️
Continental 25.09% <ø> (+0.02%) ⬆️
Robosense 0.00% <ø> (ø)

Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit 2719e64 into tier4:main Feb 25, 2025
17 of 21 checks passed
@KYabuuchi KYabuuchi deleted the feat/add_node_name_to_diag_name_velodyne branch February 25, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants