feat(velodyne): add node name to diag name of hesai hw_monitor #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
This applies the same changes to vleodyne as #217
Description
Added namespace so that velodyne_hw_monitor can diag each LiDAR.
Previously, when multiple Velodyne LiDAR drivers are running, the diagnostics for all LiDARs are labeled as
velodyne_ros_wrapper_node
, making it impossible to distinguish between them.With this fix, each LiDAR's namespace is added to the diagnostics, allowing them to be properly distinguished.
For example, the diagnostics now appear as follows:
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks