Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ars548): change config for default IP to match the factory default #280

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 25, 2025

PR Type

  • Improvement

Related Links

Description

The factory default sensor IP ends in .113 but Nebula's default was .114, which is confusing for users and doesn't make for a good out-of-the-box experience. Fixed in this PR.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Feb 25, 2025
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit 1128658 into main Feb 25, 2025
10 checks passed
@mojomex mojomex deleted the fix/ars548-default-ip branch February 25, 2025 06:04
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.48%. Comparing base (78d4fb9) to head (f4790de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   29.28%   26.48%   -2.81%     
==========================================
  Files         112      112              
  Lines        9733     9524     -209     
  Branches     3252     2123    -1129     
==========================================
- Hits         2850     2522     -328     
- Misses       6359     6578     +219     
+ Partials      524      424     -100     
Flag Coverage Δ
differential 26.48% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 18.37% <ø> (-31.87%) ⬇️
Hesai 29.69% <ø> (-0.72%) ⬇️
Velodyne 37.28% <ø> (+0.09%) ⬆️
Continental 25.09% <ø> (+0.02%) ⬆️
Robosense 0.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants