fix(nebula_hw_interfaces): mystery segmentation fault

[knzo25]

PR Type

• Bug Fix

Related Links

Description

Depending on the platform, and the day (literally), I am experiencing segmentation faults with the robosense hw decoder.
I tried to isolate the causes and to use instrumentation tools, but whenever I compiled not in release the error did not appear, so I could not make a complete report.

Conclusions I could take:

• When the error appears, it is due to the info rather than the data stream
• If I disable either of the streams it works
• If I remove the sleep mentioned in the diff, the problem disapears. Alternatively, if I replace std with boost for the sleep, it dissapears.

@mebasoglu
Is there any reason for the sleep? Would you have any objection to delete it or turn it into a boost thread sleep?

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[mojomex]

The same change has been made in the single-node-refactoring

• refactor(robosense)!: combine Robosense ROS wrappers into a single node #147
  and has been confirmed working with PCAPs. Closing this in favor of the already merged PR.

[knzo25]

@mojomex
I think the idea of the PR was for @mebasoglu to tell us if he had anything against us removing the sleep

[mebasoglu]

Hello, I apologize for the delay, I couldn't find enough time to check Nebula. I will try to take a look at.