Skip to content

Commit

Permalink
chore(hesai/decoder_wrapper): clarify watchdog behavior in decoder
Browse files Browse the repository at this point in the history
  • Loading branch information
mojomex committed May 22, 2024
1 parent 49d0664 commit 215d131
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions nebula_ros/src/hesai/decoder_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,12 @@ void HesaiDecoderWrapper::ProcessCloudPacket(std::unique_ptr<nebula_msgs::msg::N
pointcloud = std::get<0>(pointcloud_ts);
}

// A pointcloud is only emitted when a scan completes (e.g. 3599 packets do not emit, the 3600th emits one)
if (pointcloud == nullptr)
{
// todo
// RCLCPP_WARN_STREAM(logger_, "Empty cloud parsed.");
// Since this ends the function early, the `cloud_watchdog_` will not be updated.
// Thus, if pointclouds are not emitted for too long (e.g. when decoder settings are wrong or no packets come in),
// the watchdog will log a warning automatically
return;
};

Expand Down

0 comments on commit 215d131

Please sign in to comment.