Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] name dependencies, replaced for newer ones #29

Closed
wants to merge 2 commits into from

Conversation

SergioReyesSan
Copy link

PR Type

  • Bug Fix

Related Links

Description

rosdep could not resolve the dependencies because the names were old or deprecated, name dependencies were replaced for new ones and now rosdep can find and install all the dependencies.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

The dependencies names used on package.xml were old, causing a problem with rosdep when trying to find and install all the dependencies for this package.
…ncher

[Fix] name dependencies, replaced for newer ones
@SergioReyesSan
Copy link
Author

This problem was fixed by Hirabayashi san in another Pull Request, so this one is not necessary anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant