Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lidar_centerpoint): add prefix at lidar_centerpoint #20

Conversation

MasatoSaeki
Copy link

PR Type

  • refactor

Related Links

autowarefoundation/autoware.universe#8049

Description

This repository adapt to "add autoware prefix" in lidar_centerpoint

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: MasatoSaeki <[email protected]>
@MasatoSaeki MasatoSaeki changed the base branch from main to refactor/autoware-prefix July 19, 2024 04:11
@MasatoSaeki MasatoSaeki marked this pull request as ready for review July 23, 2024 00:49
Copy link

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MasatoSaeki MasatoSaeki merged commit 9ce1987 into refactor/autoware-prefix Jul 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants