Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(euclidean_cluster): add package name prefix of autoware_ #17

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Jul 12, 2024

Description

This PR adds the autoware_ prefix to the package name.

Changes are as following.

  1. Package names in CMakeLists.txt, package.xml
  2. Launch files $(find-pkg-share ...)

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569
Releated PR: autowarefoundation/autoware.universe#8003

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@badai-nguyen badai-nguyen changed the base branch from main to refactor/autoware-prefix July 21, 2024 23:19
@badai-nguyen badai-nguyen marked this pull request as ready for review July 22, 2024 01:33
Copy link

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I have no environment for testing)

@badai-nguyen
Copy link
Author

Since we collect all prefix update into refactor/autoware-prefix before before merging to main so I will merge this PR.

@badai-nguyen badai-nguyen merged commit feb01ab into tier4:refactor/autoware-prefix Jul 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants