Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_detected_objects): update roi_detected_objects_fusion node parameters #14

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

bgilby59
Copy link
Contributor

@bgilby59 bgilby59 commented Nov 2, 2023

PR Type

  • Bug Fix

Description

Update roi_detected_objects_fusion node parameters to stay up to date with Autoware Universe

Review Procedure

ros2 launch edge_auto_launch perception_at128_sample.launch.xml

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@bgilby59 bgilby59 requested review from manato and drwnz November 2, 2023 03:20
@bgilby59 bgilby59 changed the title update fusion node params update roi_detected_objects_fusion node parameters Nov 2, 2023
@drwnz drwnz changed the title update roi_detected_objects_fusion node parameters fix(roi_detected_objects): update roi_detected_objects_fusion node parameters Nov 2, 2023
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilby59 bgilby59 merged commit 8a9cc3c into main Nov 20, 2023
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants