Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/introduce sensor height #13

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Feat/introduce sensor height #13

merged 1 commit into from
Nov 7, 2023

Conversation

manato
Copy link
Collaborator

@manato manato commented Oct 12, 2023

PR Type

  • Improvement

Related Links

N/A

Description

This PR introduces a new parameter named sensor_height in the perception launch files so that sensor height from the floor can be specified as a running argument.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@manato manato force-pushed the feat/introduce_sensor_height branch from a37c130 to d48c600 Compare October 12, 2023 06:53
@manato manato requested review from drwnz and bgilby59 October 19, 2023 05:47
@manato manato marked this pull request as ready for review October 19, 2023 05:47
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit c83f95d into main Nov 7, 2023
6 of 9 checks passed
@manato manato deleted the feat/introduce_sensor_height branch November 9, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants