Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xt32 sample #10

Merged
merged 3 commits into from
Sep 29, 2023
Merged

fix: xt32 sample #10

merged 3 commits into from
Sep 29, 2023

Conversation

manato
Copy link
Collaborator

@manato manato commented Jul 18, 2023

PR Type

  • New Feature

Related Links

Description

This PR introduces a feature of roi_cluster_fusion in the XT32 sample

Review Procedure

ros2 launch edge_auto_launch perception_xt32_sample.launch.xml
# add `live_sensor:=false` option when using rosbag

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@manato manato requested review from aohsato and drwnz July 18, 2023 13:36
@manato manato marked this pull request as ready for review July 19, 2023 03:14
@manato manato requested a review from bgilby59 August 28, 2023 03:01
Copy link
Contributor

@bgilby59 bgilby59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ROSCube and Laptop. Results were as expected.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit 4806b8e into main Sep 29, 2023
10 of 11 checks passed
@manato manato deleted the fix/xt32_sample branch September 29, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants