Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remap profile #48

Merged
merged 9 commits into from
Nov 18, 2024
Merged

feat: remap profile #48

merged 9 commits into from
Nov 18, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Nov 15, 2024

Types of PR

  • New Features

Description

  • change launch argument remap -> remap_arg
  • add remap_profile to select remap config file

How to review this PR

TIER IV internal

# experiment/beta/v3.1.0-LSimV2Test
webauto ci scenario run --project-id x2_dev --scenario-id 2cd3f673-cf0e-4437-9d60-314ff6d2c909 --scenario-version-id 5 --scenario-parameters 't4_dataset_id=f0cfb74d-d35f-490f-b237-115a0738b921,t4_dataset_version_id=0' --simulation-name perception
  • please confirm remap command in your terminal
  • please confirm remapped msg(s)
# confirm remap command
[INFO] [launch.user]: remap_command is ['--remap', '/sensing/lidar/concatenated/pointcloud:=/unused/sensing/lidar/concatenated/pointcloud', '/perception/obstacle_segmentation/pointcloud:=/unused/perception/obstacle_segmentation/pointcloud', '/perception/object_recognition/objects:=/unused/perception/object_recognition/objects', '/perception/object_recognition/detection/rois0:=/unused/perception/object_recognition/detection/rois0', '/perception/object_recognition/detection/rois1:=/unused/perception/object_recognition/detection/rois1', '/perception/object_recognition/detection/rois2:=/unused/perception/object_recognition/detection/rois2', '/perception/object_recognition/detection/rois3:=/unused/perception/object_recognition/detection/rois3', '/perception/object_recognition/detection/rois4:=/unused/perception/object_recognition/detection/rois4', '/perception/object_recognition/detection/rois5:=/unused/perception/object_recognition/detection/rois5', '/perception/object_recognition/detection/rois6:=/unused/perception/object_recognition/detection/rois6', '/perception/object_recognition/detection/rois7:=/unused/perception/object_recognition/detection/rois7']

# confirm remapped msg(s)
ros2 topic echo /unused/perception/object_recognition/detection/rois0

Others

Signed-off-by: Hayato Mizushima <[email protected]>
Signed-off-by: Hayato Mizushima <[email protected]>
Signed-off-by: Hayato Mizushima <[email protected]>
Signed-off-by: Hayato Mizushima <[email protected]>
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Contributor

@TadaKazuto TadaKazuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evaluatorで実行して期待通りの動作を確認できました。

@hayato-m126 hayato-m126 merged commit 05efb9d into develop Nov 18, 2024
5 checks passed
@hayato-m126 hayato-m126 deleted the feat/remap-profile branch November 18, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants