Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid merge conflicts in NEWS file #913

Merged
merged 1 commit into from
Feb 25, 2014
Merged

Avoid merge conflicts in NEWS file #913

merged 1 commit into from
Feb 25, 2014

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 25, 2014

by using the union merge strategy.

This will simplify life for contributors. Unfortunately, GitHub does not seem to support this for browser-based merging, but merges on the command line will not suffer from merge conflicts in NEWS anymore.

See also http://krlmlr.github.io/using-gitattributes-to-avoid-merge-conflicts/.

hadley added a commit that referenced this pull request Feb 25, 2014
Avoid merge conflicts in NEWS file
@hadley hadley merged commit 6c18843 into tidyverse:master Feb 25, 2014
@hadley
Copy link
Member

hadley commented Feb 25, 2014

Cool - thanks!

@krlmlr krlmlr deleted the gitattributes-NEWS branch February 25, 2014 15:23
@krlmlr
Copy link
Member Author

krlmlr commented Feb 25, 2014

If new items are added to the top of the NEWS file, the order of the fixes seems to remain consistent.

@krlmlr
Copy link
Member Author

krlmlr commented Feb 25, 2014

Also, please consider using

hub merge PULLREQ_URL

on the command line in favor of the "Merge" button at GitHub; the former will take advantage of the new .gitattributes merge setting, avoiding the extra roundtrip required just to resolve the non-conflict in NEWS. From the docs:

git merge PULLREQ-URL
Merge the pull request with a commit message that includes the pull request ID and title, similar to the GitHub Merge Button.

@hadley
Copy link
Member

hadley commented Feb 25, 2014

Ok, I'll give that a go next time.

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants