Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the input panels for Facet$draw_panesl predicatable #6407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make the input panels for Facet$draw_panesl predicatable #6407

wants to merge 2 commits into from

Conversation

Yunuuuu
Copy link
Contributor

@Yunuuuu Yunuuuu commented Apr 9, 2025 •
edited
Loading

fix #6406

This PR just make sure the panels input for Facet$draw_panel follows the shape:

It'll be a list of gTree object for each panel: each gTree object contains 3 children for Coord$render_fg, Coord$render_bg and another gTree of Facet$draw_back, all layer grobs, and Facet$draw_front

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Apr 9, 2025 •
edited
Loading

I'm curious: why doesn't get_layer_grob() return the grob directly, but instead returns a list with just one element?

@teunbrand teunbrand mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: make the input panels of Facet$draw_panels() predictable
1 participant
@Yunuuuu