Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starwars data - Replace defunct API #6938

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

steveharoz
Copy link
Contributor

@steveharoz steveharoz commented Oct 8, 2023

  1. The API used to generate the starwars data is no longer operational. I found 2 possible replacements (https://swapi.dev/about and https://swapi.py4e.com/about). The py4e site was more complete, so I used that one.
  2. A typo was pointed out in Update starwars.csv #6840. The issue was fixed in swapi.dev but not in swapi.py4e.com, so I just fixed it myself in the code.
  3. One character's details (Jek Tono Porkins) were missing from the new API, so I added them in code using the old data.
  4. The order of the films was arbitrary in the old API. The new API sorts it by release date. (This is the bulk of the diff)
  5. There are only very minor changes to the other data coming from the new API. So there shouldn't be much impact.

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other places where we lost data in the switch to the new API, but we also gained some too. I don't think we want to do too much manual tweaking, so I've removed your Jek adjustment for now (I think we'd either try to do all or nothing, and since Gregar and Corde also lost info, I think it is better to try to consistently do nothing right now)

Comment on lines -58 to +61
Gregar Typho,185,85,black,dark,brown,NA,male,masculine,Naboo,Human,Attack of the Clones,,Naboo fighter
Cordé,157,NA,brown,light,brown,NA,female,feminine,Naboo,Human,Attack of the Clones,,
Plo Koon,188,80,none,orange,black,22,male,masculine,Dorin,Kel Dor,"The Phantom Menace, Attack of the Clones, Revenge of the Sith",,Jedi starfighter
Mas Amedda,196,NA,none,blue,blue,NA,male,masculine,Champala,Chagrian,"The Phantom Menace, Attack of the Clones",,
Gregar Typho,185,85,black,dark,brown,NA,NA,NA,Naboo,NA,Attack of the Clones,,Naboo fighter
Cordé,157,NA,brown,light,brown,NA,NA,NA,Naboo,NA,Attack of the Clones,,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost data here too

@DavisVaughan DavisVaughan merged commit 2e191ff into tidyverse:main Nov 3, 2023
11 checks passed
@DavisVaughan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants