Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for closest() #6882

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add tests for closest() #6882

merged 1 commit into from
Jul 17, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 16, 2023

I haven't found any behavior tests in the test suite.

@DavisVaughan
Copy link
Member

I think this was because I have a massive amount of behavior testing in vctrs for vec_locate_matches(), and ended up mostly testing interface stuff here, but some basic tests seem fine / useful since you use them in duckplyr

@DavisVaughan DavisVaughan merged commit 3125697 into main Jul 17, 2023
11 checks passed
@DavisVaughan DavisVaughan deleted the f-closest-test branch July 17, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @DavisVaughan