Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix td translations #1545

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Fix td translations #1545

merged 6 commits into from
Oct 24, 2024

Conversation

rplsmn
Copy link
Contributor

@rplsmn rplsmn commented Oct 14, 2024

Fixed as.character and as.double for Teradata

@rplsmn
Update numeric to float for double
665eedd
@rplsmn
Update as.character
c898924 
Ajout d'un argument pour le nombre chars
Par défaut 255
Corrige le bug
@rplsmn rplsmn closed this Oct 14, 2024
@simonpcouch
Copy link
Collaborator

Intended to close #1544.

@rplsmn, thanks for the thorough issue description there! It appears you've closed this PR—did you intend to do so? If so, would you be interested in working together to get those checks passing and the PR merged?

@rplsmn
Copy link
Contributor Author

rplsmn commented Oct 16, 2024

Hello,

I had opened this PR by mistake while trying to open a PR elsewhere, and since it happened before anyone gave me the permission on my issue I felt like I was being very impolite so I closed it until someone gave me the green light :)
Should I reopen it then ?
I'm very interested in working together on this, yes !

@rplsmn
Add tests for changed td translations
e66987e 
Modified the test for as.double
Modified and added a new test for as.character
@rplsmn rplsmn reopened this Oct 16, 2024
@rplsmn
Copy link
Contributor Author

rplsmn commented Oct 23, 2024

Hi, I'm just checking in to ask if I forgot something here ?
I understand that these things take time, there is no rush and this is not a message to get anyone to react faster !
This is my first real PR so I don't want it to be hanging because of a mistake on my side.

simonpcouch
simonpcouch approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm just checking in to ask if I forgot something here ?

Nope, all good! Just took me a bit to get to it.

These changes look solid to me. I'm approving merge, but going to ping another reviewer internally before doing so.

@simonpcouch simonpcouch linked an issue Oct 24, 2024 that may be closed by this pull request
Teradata incorrect sql_translation for scalar "as.double" and "as.character" #1544
Closed
@rplsmn @simonpcouch
Update R/backend-teradata.R
5c40830 
Co-authored-by: Simon P. Couch <[email protected]>
@rplsmn
Copy link
Contributor Author

rplsmn commented Oct 24, 2024

Hello, I hope I clicked in the right places !
Thank you

@simonpcouch simonpcouch merged commit 7fb52d7 into tidyverse:main Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley left review comments

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teradata incorrect sql_translation for scalar "as.double" and "as.character"
3 participants
@rplsmn @simonpcouch @hadley