Skip to content

Fix issue #206 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #206 #207

wants to merge 1 commit into from
+1 −1

Conversation

lgaborini
Copy link

@lgaborini lgaborini commented Jun 6, 2025 •
edited
Loading

Just a minor typo, the code in the issue #206 now works.

I can't find any test with a tune() within hier_clust() model, am I correct?

@EmilHvitfeldt
Copy link
Member

Hello @lgaborini 👋

Thanks for writing the PR, it does appear there isn't a test. Are you up for adding one in this PR?

@lgaborini
Copy link
Author

lgaborini commented Jun 10, 2025 •
edited
Loading

Sure! Should I duplicate each test in tests/testthat/test-tune_cluster.R to test hier_clust(), or is it overkill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgaborini @EmilHvitfeldt