Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos of over_ratio and under_ratio #146

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix typos of over_ratio and under_ratio #146

merged 3 commits into from
Dec 6, 2023

Conversation

jxu
Copy link
Contributor

@jxu jxu commented Dec 6, 2023

Fixes #143 and fixes #110: majority-to-minority and minority-to-majority appear to be backwards.

Does not change generated documentation like REAMDE.md and man .Rd files. I don't know how these are generated.

jxu and others added 3 commits December 6, 2023 10:59
Fixes #143 and #110: majority-to-minority and minority-to-majority appear to be backwards.
Does not change generated documentation like REAMDE.md and man .Rd files.
@EmilHvitfeldt
Copy link
Member

Thank you!!

@EmilHvitfeldt EmilHvitfeldt merged commit 0f3709a into tidymodels:main Dec 6, 2023
@jxu
Copy link
Contributor Author

jxu commented Dec 6, 2023

I'm not able to install tidytemplate and pkgdown on windows (says no package ‘tidytemplate’ is not available for this version of R, 4.2.3). I assume running build_site() will update all the documentation?

@EmilHvitfeldt
Copy link
Member

That it not needed. The documentation is updated by running devtools::document(), and by knitting the readme file.

pkgdown::build_site() creates the pkgdown site you see at recipes.tidymodels.org, but you don't need to do that, as it is done automatically with Github Actions

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

step_downsample() under_ratio docs Is the description of under_ratio in step_downsample() correct?
2 participants