-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quantile_pred #260
add quantile_pred #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I review, since this is easier for you to affirm verbally than for me to tell via diffs: are there differences in the implementation proposed here vs. the one just merged into parsnip?
The only difference that I can think of is that I had to import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Co-authored-by: Simon P. Couch <[email protected]>
From tidymodels/parsnip#1191
After this PR, we will add a remote to parsnip for this version, then remove the redundant functions.