Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix typos #357

wants to merge 4 commits into from

Conversation

ccoVeille
Copy link

  • Format files before working on them
  • Fix JSON acronym
  • Fix typos and style
  • Use backtick for JSON node name, not quotes

@ccoVeille
Format files before working on them
0b9aa79 
gjson_test.go was formatted with gofumpt
@ccoVeille
Fix JSON acronym
49fb81d 
An acronym is written in capital.
@ccoVeille
Copy link
Author

Hi @tidwall

Is there anything you need from me before reviewing my PR?

I'm asking because I may also work on a code review based on golangci-lint input.

I wanted to start with a simple PR to see if you were open for PR contributions.

I also, contributed to tidwall/sjson#82

And I intended to open a code review on sjson too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ccoVeille