Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): reviving PR #12411 for ios background tasks #14142

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AbdullahFaqeir
Copy link
Contributor

@AbdullahFaqeir AbdullahFaqeir commented Nov 9, 2024

This PR is solely to revive PR #12411

@AbdullahFaqeir AbdullahFaqeir changed the title feat(ios): reviving PR (#12411) for ios background tasks feat(ios): reviving PR #12411 for ios background tasks Nov 9, 2024
@AbdullahFaqeir
Copy link
Contributor Author

@hansemannn @m1ga if we can check this

@m1ga
Copy link
Contributor

m1ga commented Nov 12, 2024

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

@AbdullahFaqeir
Copy link
Contributor Author

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

@m1ga already cleaned up

@m1ga
Copy link
Contributor

m1ga commented Nov 12, 2024

@AbdullahFaqeir
Copy link
Contributor Author

I only reverted the file to it's original content from the main repo

@m1ga
Copy link
Contributor

m1ga commented Nov 12, 2024

That part (and the other file you reverted already) is from your other PR: https://github.com/tidev/titanium-sdk/pull/14137/files . It looks like you didn't start from the master branch to start the PR but from this branch ios-dark-mode-icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants