Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow ignoreLog to be a single string #14116

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: allow ignoreLog to be a single string #14116

merged 1 commit into from
Sep 23, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Sep 17, 2024

Currently if you use ignoreLog with just a single string instead of an array it will show lots of

TypeError: ignoreLog.some is not a function at printData`

errors in the log.

This PR will allow strings.

Test

  • edit ~/.titanium/config.json and set "ignoreLog": "Too many Flogger logs received before configuration"
  • build an app

@hansemannn hansemannn merged commit 4a543ab into master Sep 23, 2024
5 checks passed
@hansemannn hansemannn deleted the ignoreLogString branch September 23, 2024 10:28
hansemannn pushed a commit that referenced this pull request Sep 23, 2024
@m1ga @hansemannn
fix: allow ignoreLog to be a single string (#14116)
15b0eb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @hansemannn