Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): improve accessibility text #14036

Merged
merged 3 commits into from
May 24, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented May 15, 2024

By default all views/items will have say "double click to activate and for a long press double click and hold". Most items don't use a long press/click so it would be nice to deactive that message. This PR will add accessibilityDisableLongPress that you can use to disable that message.

Test:

  • enable TalkBak
  • run the code below
  • click the label: old behavior - will say double click and long click
  • click the button: new behavior - will only say "double click to activate"
var win1 = Titanium.UI.createWindow({layout:"vertical"});
var text1 = Titanium.UI.createLabel({text: 'Hello Wold'});

var button = Titanium.UI.createButton({
  title: 'button',
  accessibilityHint: "click",
  accessibilityLabel: "button",
  accessibilityValue: "click me",
  accessibilityDisableLongPress: true
});

win1.add([text1, button]);
win1.open();

@m1ga m1ga added the feature label May 23, 2024
@m1ga m1ga requested a review from cb1kenobi May 23, 2024 10:38
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! APPROVED!

@cb1kenobi cb1kenobi merged commit 3171e14 into master May 24, 2024
7 checks passed
@m1ga m1ga deleted the androidAccessibilityLongPress branch May 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants