Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix Android FAB tintColor #13972

Merged
merged 2 commits into from
Feb 11, 2024
Merged

fix(android): fix Android FAB tintColor #13972

merged 2 commits into from
Feb 11, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jan 22, 2024

Fixes #13971

Currently tintColor is not tinting the icon. This PR will fix that

Test:

const win = Ti.UI.createWindow();
const fab = Ti.UI.Android.createFloatingActionButton({
	bottom: 10,
	right: 10,
	tintColor: "blue",
	image: "/appicon.png"
});
win.add(fab);

setTimeout(function() {
	fab.tintColor = "red";
}, 2000)
win.open();
  • icon will be blue
  • after 2 sec it will be red

@m1ga m1ga mentioned this pull request Jan 22, 2024
Closed
1 task
@hansemannn hansemannn merged commit 60cb3f5 into master Feb 11, 2024
7 checks passed
hansemannn pushed a commit that referenced this pull request Feb 11, 2024
@m1ga @hansemannn
fix(android): fix Android FAB tintColor (#13972)
0c1bf92 
* fix(android): fix Android FAB tintColor

* remove from excludes
@m1ga m1ga deleted the fabTint branch March 21, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android: FAB tintColor
2 participants
@m1ga @hansemannn