-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): support for html in AttributedStrings #13569
Conversation
Added support for html key when creating an AttributedString. If html is not present it fallbacks to previous behavior
Hi, thanks for the contribution. Can you add a simple example please so people can quickly test it. And have a look at https://github.com/tidev/titanium_mobile/blob/master/apidoc/Titanium/UI/AttributedString.yml and ad your property so it is visible in the documentation. Check this page https://github.com/tidev/organization-docs/blob/main/AUTHORIZED_CONTRIBUTORS.md on how to become a contributor. |
Once the CLA is signed, we can go ahead! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look fine
I've signed on Wednesday, don't know if I need to do anything else |
cc @joshualambert ? |
Confirmed -- we now have a CLA signature for @Brianggalvez. Added him to authorized CLA list here: https://github.com/tidev/organization-docs/blob/main/AUTHORIZED_CONTRIBUTORS.md |
The CLA action seems to have an issue:
Maybe because of |
I've tested a bit with this PR (it works great!) and noticed that on Android, there is the "html" property on the label itself already. I am wondering if iOS could potentially also use this property and construct the |
@Brianggalvez I've added the suggested changes in this PR to your branch: Brianggalvez#38 Great new API! |
Added support for html key when creating an AttributedString. If html is not present it fallbacks to previous behavior