BG data plotted on a log scale

[jebeck]

@HowardLook please sign off on the list of implemented changes here (to close #44) and also whether this change is considered to solve issue #34 with respect to the typography on the y-axis (referencing its appearance here which is the dimensions that blip will be updated to soon)

What's implemented here is:

• BG data plotted on a log scale, with the min and max of the y-axis set to the extent of the data that's loaded (i.e., accessible from the scrollbar)
• average BG "floater" also on a log scale

[HowardLook]

Happy to take a look. Is it deployed? Where to? I tried blip-devel and I don’t see it there.

Thanks,
H

On Mar 5, 2014, at 6:17 PM, Jana Beck [email protected] wrote:

@HowardLook please sign off on the list of implemented changes here (to close #44) and also whether this change is considered to solve issue #34 with respect to the typography on the y-axis (referencing its appearance here which is the dimensions that blip will be updated to soon)

What's implemented here is:

BG data plotted on a log scale, with the min and max of the y-axis set to the extent of the data that's loaded (i.e., accessible from the scrollbar)
average BG "floater" also on a log scale
You can merge this Pull Request by running

git pull https://github.com/tidepool-org/tideline jebeck/bg-log-scale-2
Or view, comment on, or merge it at:

#47

Commit Summary

actual domain-determined, base-10 log scale for BG pool
make stats widget BG floater use a log scale too
Merge branch 'master' into jebeck/bg-log-scale-2
File Changes

M example/chartdailyfactory.js (9)
M js/plot/smbg.js (2)
M js/plot/stats/widget.js (2)
M js/plot/util/scales.js (10)
Patch Links:

https://github.com/tidepool-org/tideline/pull/47.patch
https://github.com/tidepool-org/tideline/pull/47.diff
—
Reply to this email directly or view it on GitHub.

[jebeck]

I linked to the gh-pages gallery page for this branch, which now has the exact dimensions blip will soon have, so that should be sufficient to sign off on a change just to the viz. Let me know if you disagree.

[kentquirk]

I was going to comment some more on the log scale choices -- but in looking things over, I've decided that we have spent more than enough energy on this issue and should make a decision and move on with our lives. I think this is more than Good Enough and we should just accept it. But @HowardLook gets the final call.

[HowardLook]

I am confortable proceeding for Pilot with it as presented in bg-log-scale-2. We can review later when we have more information but agree that we have plenty of other things to work on now.

@brandonarbiter said he's going to think about alternate numerical labels which I'm fine reviewing, but I'm also fine leaving it as is.

Thanks,
H

[jebeck]

@HowardLook can you answer whether bg-log-scale-2 is also good enough for closing the typography issue wrt to the y-axis (#34)?

[HowardLook]

Yes, it is good enough for Pilot, and looks great. Thanks!

On Mar 6, 2014, at 12:22 PM, Jana Beck [email protected] wrote:

@HowardLook can you answer whether bg-log-scale-2 is also good enough for closing the typography issue wrt to the y-axis (#34)?

—
Reply to this email directly or view it on GitHub.