Merge pull request #3 from tidepool-org/add-list-users-endpoint

Do not try to serialize non-existent users
tidepool-org · Sep 9, 2020 · ebc9db9 · ebc9db9
2 parents 72b857f + b5f1eb8
commit ebc9db9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/admin/src/main/java/org/tidepool/keycloak/extensions/resource/TidepoolAdminResource.java b/admin/src/main/java/org/tidepool/keycloak/extensions/resource/TidepoolAdminResource.java
@@ -16,7 +16,7 @@
 
 public class TidepoolAdminResource extends AdminResource {
 
-    private final String ID_SEPARATOR = ",";
+    private static final String ID_SEPARATOR = ",";
 
     private final KeycloakSession session;
 
@@ -37,7 +37,9 @@ public Response getUsersById(@QueryParam("ids") String ids) {
 
             for (String id : ids.split(ID_SEPARATOR)) {
                 UserModel user = provider.getUserById(id, realm);
-                representations.add(toRepresentation(user, realm));
+                if (user != null) {
+                    representations.add(toRepresentation(user, realm));
+                }
             }
         }