Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move care partner alerts APNS config to its own helm chart #316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ewollesen
Copy link
Contributor

So it can more easily be shared by the data and task services, which
both make use of it.

BACK-2559

darinkrauss
darinkrauss previously approved these changes Feb 28, 2025
Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a question and a nit.

name: care-partner-alerts
key: APNSBundleID
optional: true
{{ end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at EOF.

configmap:
enabled: true
data_:
APNSKeyID: "QA3495JW4S"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we use the same APNS key id for production and non-production?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, yes. We have only the one key.

At time of submission we can select to use a Sandbox service, but the key remains the same.

So it can more easily be shared by the data and task services, which
both make use of it.

BACK-2559
It's moved to a template now.

BACK-2559
Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants