fix: assign omitBy result to variable

tidepool-org · Jan 23, 2025 · 6f71e00 · 6f71e00
1 parent d91be19
commit 6f71e00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/bootstrap.js b/app/bootstrap.js
@@ -63,9 +63,9 @@ appContext.trackMetric = (...args) => {
   };
 
   // Empty values should be omitted from the metadata object to prevent sending blank query params
-  _.omitBy(eventMetadata, _.isNil);
+  const filteredEventMetadata = _.omitBy(eventMetadata, _.isNil);
 
-  _.defaultsDeep(args, [, eventMetadata]);
+  _.defaultsDeep(args, [, filteredEventMetadata]);
 
   return appContext.api.metrics.track.apply(appContext.api.metrics, args);
 };

diff --git a/app/redux/utils/trackingMiddleware.js b/app/redux/utils/trackingMiddleware.js
@@ -38,9 +38,9 @@ const interpretMetricMap = {
     let eventMetadata = { clinician, mobile };
 
     // Empty values should be omitted from the metadata object to prevent sending blank query params
-    _.omitBy(eventMetadata, _.isNil);
+    const filteredEventMetadata = _.omitBy(eventMetadata, _.isNil);
 
-    return { eventName: 'Logged In', properties: eventMetadata };
+    return { eventName: 'Logged In', properties: filteredEventMetadata };
   },
   SETUP_DATA_STORAGE_SUCCESS: function(action) {
     const diagnosisType = _.get(action, 'payload.patient.profile.patient.diagnosisType');