Qae 222 #37
Open
Qae 222 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brian-tidepool
commented
Aug 16, 2024
brian-tidepool
commented
- implements https://tidepool.atlassian.net/browse/QAE-222
- logins as clinician and access custodial user, verifies upload button and resend verification email link is present
Rpm Stats Automated Tests
…end verification email
|
also merged fixes from suppressednotifiactiontest branch. only need to review the new changes from commit 2faf95f |
tests name,dob,diagnosis date, diagnosis type, mrn, bio
vojtech-cerveny
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Hey,
some my points (questions) are kinda "general" how we should write tests. So it would be nice to know opinion on that from @ginnyyadav .
From my point of view, it needs some changes. But I get it, that it is in same style as already commited files/tests.
-rename tag qae222 to qae-222 -rename test to Clinician is able to select workspace -add assertion to test
tests name,dob,diagnosis date, diagnosis type, mrn, bio
-login test -go to workspace test -tag name
function checkFile -> checkFileExistence documentation added/updated
function checkFile -> checkFileExistence documentation added/updated
Co-authored-by: Vojtěch Červený <[email protected]>
ginnyyadav
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.