Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ip_addresses to match new format in sync #264

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Update ip_addresses to match new format in sync #264

merged 2 commits into from
Oct 5, 2023

Conversation

justinbarclay
Copy link
Member

No description provided.

prees1
prees1 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@prees1 prees1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the windows version of machine-stats need a change similar to this one?

@justinbarclay
Copy link
Member Author

Will the windows version of machine-stats need a change similar to this one?

That is a good question, I looked through the code and I couldn't find us capturing IP info anywhere. I eventually read the readme and it doesn't look like it captures IP info at all: https://github.com/tidalmigrations/machine_stats/tree/master/windows#data-captured

@justinbarclay justinbarclay merged commit 32034db into master Oct 5, 2023
2 checks passed
@justinbarclay justinbarclay deleted the jb/change-ip-addresses branch October 5, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prees1 prees1 prees1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinbarclay @prees1