Add first draft of Catalogue.md #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a basic draft of the catalogue definition. There is nothing defined but the initializer so far.
stefanmoro
reviewed
Jul 17, 2024
Catalogue.md
Outdated
| @@ -0,0 +1,20 @@ | |||
| # Catalogue | |||
|
|
|||
| The TIDAL Catalogue module is a wrapper around our [Catalogue API](https://developer.tidal.com/reference/web-api?spec=catalogue). | |||
There was a problem hiding this comment.
This links to our old catalogue API - it should link to the JSON:API one.
There was a problem hiding this comment.
Hm, do you have the concrete link?
I put this link because it's the developer portal page. Or should I rather use this one?
There was a problem hiding this comment.
Nah, not the OAS. At the top of api ref you have a drop down to select different doimains. We will deprecate the "V1" shortly and only have JSON API ones. So you should link to the "new" catalogue: https://developer.tidal.com/reference/web-api?spec=catalogue-v2&ref=get-albums-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a basic draft of the catalogue definition. There is nothing defined but the initializer so far.
We can a) approve it and come back to it to add more details, or b) keep the PR open until we are happy with the result.