Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-168: Make redirect uri configurable #84

Merged
merged 1 commit into from
Sep 10, 2024
Merged

MF-168: Make redirect uri configurable #84

merged 1 commit into from
Sep 10, 2024

Conversation

stoyicker
Copy link
Member

This allows working with clients whose redirect uri is not the same as that from the TIDAL app.

@stoyicker stoyicker requested a review from a team as a code owner August 5, 2024 07:23
@stoyicker
Copy link
Member Author

@stefanmoro @michpohl ping

@stoyicker
MF-168: Make redirect uri configurable
6c2e1ae 
This allows working with clients whose redirect uri is not the same as that
from the TIDAL app.
@stoyicker stoyicker force-pushed the jantonio/configurable_redirect_uri branch from 2e6f6e0 to 6c2e1ae Compare August 30, 2024 11:07
@stoyicker stoyicker changed the title Make redirect uri configurable MF-168: Make redirect uri configurable Aug 30, 2024
michpohl
michpohl approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@michpohl michpohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much agree with this change - I did the same one time, but it didn't mature into a PR. Glad you did it!

@stoyicker stoyicker requested a review from a team September 4, 2024 10:59
@stoyicker stoyicker added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 78c16b1 Sep 10, 2024
7 checks passed
@stoyicker stoyicker deleted the jantonio/configurable_redirect_uri branch September 10, 2024 08:49
@stoyicker stoyicker mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michpohl michpohl michpohl approved these changes

@stefanmoro stefanmoro Awaiting requested review from stefanmoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoyicker @michpohl