Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media3 to 1.2.1 #109

Closed
wants to merge 1 commit into from
Closed

Update media3 to 1.2.1 #109

wants to merge 1 commit into from

Conversation

ziad-halabi9
Copy link
Contributor

@ziad-halabi9 ziad-halabi9 commented Oct 8, 2024

This update is required to fix a Dolby Atmos issue that was fixed in version 1.2.1.

Change log here.

A lot of APIs are now marked as @UnstableApi. Do we prefer to suppress per-case as done in this PR or globally suppress them?

@ziad-halabi9 ziad-halabi9 requested a review from a team as a code owner October 8, 2024 12:19
@ziad-halabi9 ziad-halabi9 force-pushed the ziad/update-media3 branch 10 times, most recently from f485104 to b023337 Compare October 8, 2024 15:00
Copy link
Member

@stoyicker stoyicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my preference would be

  1. understanding why everything is marked like this so we can decide if we need to do something about it
  2. individual suppress
  3. global suppress

then again, potato potato

@ziad-halabi9
Copy link
Contributor Author

For their demos and libraries, they suppress it by adding lint.xml:

<?xml version="1.0" encoding="utf-8"?>
<lint>
  <issue id="UnsafeOptInUsageError">
    <option name="opt-in" value="androidx.media3.common.util.UnstableApi" />
  </issue>
</lint>

File: https://github.com/androidx/media/blob/release/libraries/lint.xml

So alternatively we can do the same: #110

I see these @UnstableApi has always been there (prior to v1.2.1) but the way they were suppressed have changed and hence why we see this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants