Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out auth token refresh and setCredentials synchronization #101

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Sort out auth token refresh and setCredentials synchronization #101

merged 5 commits into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. Inject shared mutex for both LoginRepository and TokenRepository

    @michpohl
    michpohl committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    57934f6 View commit details
    Browse the repository at this point in the history

  2. Wrap backendCalls with withContext(Dispatchers.IO) 

    We know that this is done by our networking lib anyways. However, it makes sense to switch over to the correct context as early as possible
    @michpohl
    michpohl committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9b1b3de View commit details
    Browse the repository at this point in the history

  3. Add tests to ensure our mutex prevents saving of credentials while a … 

    …refresh is in flight
    @michpohl
    michpohl committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e4bfa06 View commit details
    Browse the repository at this point in the history

  4. Remove some stray print statements 

    These are unrelated to the logic, but since they were missed earlier, I took the opportunity to remove them.
    @michpohl
    michpohl committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ab807b5 View commit details
    Browse the repository at this point in the history

  5. Pass dispatcher as optional constructor arg into auth's TokenRepository 

    Running suspend funs in here using withContextbdDispatchers.IO) now forces us to be able to inject a CoroutineDispatcher, as otherwise tests won't work.
    @michpohl
    michpohl committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    08ea6b9 View commit details
    Browse the repository at this point in the history