MF-171: Introduce exception type for post-release PlaybackEngine usag…

…e attempts This allows for a more robust test as well as easier host-side checks.
tidal-music · Aug 30, 2024 · f8c9ed1 · f8c9ed1
1 parent 6396b00
commit f8c9ed1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/...n/src/main/kotlin/com/tidal/sdk/player/common/PlaybackEngineUsageAfterReleaseException.kt b/...n/src/main/kotlin/com/tidal/sdk/player/common/PlaybackEngineUsageAfterReleaseException.kt
@@ -0,0 +1,4 @@
+package com.tidal.sdk.player.common
+
+class PlaybackEngineUsageAfterReleaseException :
+    IllegalStateException("Attempted to use a released PlaybackEngine")
diff --git a/...engine/src/main/kotlin/com/tidal/sdk/player/playbackengine/SingleHandlerPlaybackEngine.kt b/...engine/src/main/kotlin/com/tidal/sdk/player/playbackengine/SingleHandlerPlaybackEngine.kt
@@ -1,6 +1,7 @@
 package com.tidal.sdk.player.playbackengine
 
 import android.os.Handler
+import com.tidal.sdk.player.common.PlaybackEngineUsageAfterReleaseException
 import com.tidal.sdk.player.common.model.AudioQuality
 import com.tidal.sdk.player.common.model.LoudnessNormalizationMode
 import com.tidal.sdk.player.common.model.MediaProduct
@@ -78,8 +79,7 @@ internal class SingleHandlerPlaybackEngine(
 
     private fun postOrThrow(runnable: Runnable) {
         if (!handler.post(runnable)) {
-            val className = SingleHandlerPlaybackEngine::class.simpleName
-            error("Attempt to use a released instance of $className")
+            throw PlaybackEngineUsageAfterReleaseException()
         }
     }
 }
diff --git a/...engine/src/test/kotlin/com/tidal/sdk/player/playbackengine/ExoPlayerPlaybackEngineTest.kt b/...engine/src/test/kotlin/com/tidal/sdk/player/playbackengine/ExoPlayerPlaybackEngineTest.kt
@@ -473,6 +473,7 @@ internal class ExoPlayerPlaybackEngineTest {
 
         playbackEngine.release()
 
+        verify(initialExtendedExoPlayer).currentPositionMs
         verify(initialExtendedExoPlayer).release()
         verifyNoMoreInteractions(initialExtendedExoPlayer, looper)
     }

diff --git a/player/src/androidTest/kotlin/com/tidal/sdk/player/playlog/SingleMediaProductPlayLogTest.kt b/player/src/androidTest/kotlin/com/tidal/sdk/player/playlog/SingleMediaProductPlayLogTest.kt
@@ -18,6 +18,7 @@ import com.tidal.sdk.common.TidalMessage
 import com.tidal.sdk.eventproducer.EventSender
 import com.tidal.sdk.eventproducer.model.ConsentCategory
 import com.tidal.sdk.player.Player
+import com.tidal.sdk.player.common.PlaybackEngineUsageAfterReleaseException
 import com.tidal.sdk.player.common.model.MediaProduct
 import com.tidal.sdk.player.common.model.ProductType
 import com.tidal.sdk.player.events.EventReporterModuleRoot
@@ -149,9 +150,10 @@ internal class SingleMediaProductPlayLogTest {
                 player.release()
                 job.join()
             }
-        } catch (alreadyReleasedException: IllegalStateException) {
-            assertThat(alreadyReleasedException.message)
-                .isEqualTo("Attempt to use a released instance of SingleHandlerPlaybackEngine")
+        } catch (throwable: Throwable) {
+            if (throwable !is PlaybackEngineUsageAfterReleaseException) {
+                throw throwable
+            }
         }
         verify(eventSender, atMost(Int.MAX_VALUE))
             .sendEvent(