Merge pull request #706 from chiragg928/fix(hybridSelect)

fix(hybridSelect): prevent label prop pass to Select
ticketmaster · Feb 16, 2021 · 75acdfd · 75acdfd
2 parents 997e5d5 + 1c48fe5
commit 75acdfd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/catalog/pages/inputs/HybridSelectExample.js b/catalog/pages/inputs/HybridSelectExample.js
@@ -49,8 +49,8 @@ export default class HybridSelectExample extends Component {
             Option Two
           </HybridOption>
           {/* Add prop optionText while children is not plain text */}
-          <HybridOption value="2" index={2} optionText=" Option Three">
-            <div>Option Three</div>
+          <HybridOption value="2" index={2} optionText="Option Three">
+            {label ? "Option Three" : <div>Option Three</div>}
           </HybridOption>
           <HybridOption value="3" index={3}>
             Option Four

diff --git a/src/components/Input/HybridDropDown/HybridSelect.js b/src/components/Input/HybridDropDown/HybridSelect.js
@@ -115,7 +115,6 @@ class HybridSelect extends Component {
           showSelect={showNativeSelect}
           value={value[0]}
           selectRef={selectRef}
-          label={label}
           onChange={this.updateValue}
           onMouseEnter={this.onMouseEnter}
         >

diff --git a/src/components/Input/__tests__/__snapshots__/HybridDropDown.spec.js.snap b/src/components/Input/__tests__/__snapshots__/HybridDropDown.spec.js.snap
@@ -1096,7 +1096,6 @@ Object {
       <select
         class="c1 select--large select--border hybrid"
         data-testid="test-hybridselect"
-        label="Sort By: "
       >
         <option
           value=""