feat: Support for retrying to deliver SQS message #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrjoh
changed the title
fredrjoh
force-pushed
the
support-for-keeping-or-deleting-message
branch
3 times, most recently
from
d98c89f
to
64a3b50
Compare
danhemma
reviewed
Aug 26, 2024
danhemma
approved these changes
Aug 26, 2024
fredrjoh
force-pushed
the
support-for-keeping-or-deleting-message
branch
2 times, most recently
from
16c6a5d
to
a3b40a3
Compare
naile
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Looks good. Suggestion: make the retry policy a function instead returning visibility timeout. That way a consumer can have their own backoff logic by changing that function. Ie if someone wants to do less or more aggressive backoff like linear or exponential. The function can also take exception as parameter allowing the consumer to change the logic depending on the error.
fredrjoh
force-pushed
the
support-for-keeping-or-deleting-message
branch
from
a3b40a3
to
909c3e6
Compare
fredrjoh
force-pushed
the
support-for-keeping-or-deleting-message
branch
from
909c3e6
to
5a4bbb0
Compare
IuryAlves
approved these changes
Aug 29, 2024
tibbercom-builduser
pushed a commit
that referenced
this pull request
Aug 29, 2024
# [6.2.0](v6.1.4...v6.2.0) (2024-08-29) ### Features * Support for retrying to deliver SQS message ([#304](#304)) ([08bd12a](08bd12a))
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/tibber/issue/INVO-636/retry-when-failing-to-send-email