Add explicit variants to buildkit (rc, dev, 0.13, for now) #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
force-pushed
the
buildkit-variants
branch
2 times, most recently
from
09ab219 to
b88417c
Compare
|
(had to exclude my "backport" patch on dev where it's already fixed 😄) |
tianon
force-pushed
the
buildkit-variants
branch
from
b88417c to
2b78191
Compare
|
My favorite way to review $ diff -u path-to/tianon-bashbrew/library/buildkit <(./gsl.sh)
--- path-to/tianon-bashbrew/library/buildkit 2024-06-25 14:53:40.000000000 -0700
+++ /dev/fd/63 2024-06-25 14:54:28.612188442 -0700
@@ -1,8 +1,12 @@
Maintainers: Tianon Gravi <[email protected]> (@tianon)
GitRepo: https://github.com/tianon/dockerfiles.git
+GitCommit: da8faac5ad0601a8948dee69e72ec669a9da9432
+Directory: buildkit
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, riscv64, s390x
Builder: buildkit
Tags: 0.14.1, 0.14, 0, latest
-GitCommit: 59e107d98a63148d38fe48bbbf4b42d3f1534099
-Directory: buildkit
+File: Dockerfile
+
+Tags: 0.13.2, 0.13
+File: Dockerfile.0.13 |
|
Overly pedantic Tianon results in: $ diff -u path-to/tianon-bashbrew/library/buildkit <(./gsl.sh)
--- path-to/tianon-bashbrew/library/buildkit 2024-06-25 14:53:40.000000000 -0700
+++ /dev/fd/63 2024-06-25 14:57:52.738072071 -0700
@@ -1,8 +1,11 @@
Maintainers: Tianon Gravi <[email protected]> (@tianon)
GitRepo: https://github.com/tianon/dockerfiles.git
+GitCommit: 862ae508afd4aca17986a51f532dce097d23e339
+Directory: buildkit
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, riscv64, s390x
Builder: buildkit
Tags: 0.14.1, 0.14, 0, latest
-GitCommit: 59e107d98a63148d38fe48bbbf4b42d3f1534099
-Directory: buildkit
+
+Tags: 0.13.2, 0.13
+File: Dockerfile.0.13 |
whalelines
reviewed
Jun 26, 2024
But they are "obviously Tianon" versions! 🥹 |
|
Yep, just more versions (especially so we can get a rebuild of our 0.13 with that fix we need for Kong, but also so it's easier for me to test things like RCs in the future) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've been considering doing for a while (since the 0.13 series of RCs, actually), but was never quite happy with -- the advent of #743 needing a new 0.13 build encouraged me to Do The Thing (specifically to include a "0.13" variant so we can do a rebuild of 0.13 with that backported patch so we can fix the current Kong build issue in DOI without also introducing other potential issues by doing a full upgrade to 0.14 just yet).
FYI @yosifkit @whalelines @LaurentGoderre - new
tianon/buildkit:0.13incoming which should fix the Kong build issues (thanks to #743, although I still think we need to continue exploring #742).