Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CryptoPkg/BaseCryptLib: Fix serial number read overrun #6418

Merged
merged 1 commit into from
Nov 8, 2024
Merged

CryptoPkg/BaseCryptLib: Fix serial number read overrun #6418

merged 1 commit into from
Nov 8, 2024

Conversation

mdkinney
Copy link
Member

@mdkinney mdkinney commented Nov 8, 2024

Description

Fix serial number read overrun detected with use of address sanitizer in host based unit tests in draft PR #6408

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Run host based unit tests with address sanitizer enabled and the issue is resolved with this change

Integration Instructions

@github-actions github-actions bot added the impact:security This change has a direct security impact such as changing a crypto algorithm. label Nov 8, 2024
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Nov 8, 2024
@mergify mergify bot merged commit d5600f4 into tianocore:master Nov 8, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 jyao1 approved these changes

@liyi77 liyi77 liyi77 approved these changes

@lgao4 lgao4 lgao4 approved these changes

Assignees
No one assigned
Labels
impact:security This change has a direct security impact such as changing a crypto algorithm. push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdkinney @lgao4 @liyi77 @jyao1