Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use new Fedora-40 image for Linux jobs #6261

Merged
merged 3 commits into from
Dec 4, 2024
Merged

CI: Use new Fedora-40 image for Linux jobs #6261

merged 3 commits into from
Dec 4, 2024

Conversation

osteffenrh
Copy link
Contributor

@osteffenrh osteffenrh commented Sep 30, 2024 •
edited
Loading

Switch the Linux CI jobs over to the latest Fedora 40 image.

@osteffenrh
Copy link
Contributor Author

osteffenrh commented Sep 30, 2024 •
edited
Loading

(+@gguo11837463)

There is a problem with lcov version 2.0 (and newer).

See https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=152451&view=logs&jobId=7cd61938-4509-589a-75ed-329528680800 for a CI run hitting the problem.

From the log:

...
INFO - Processing /__w/1/s/Build/SecurityPkg/HostTest/NOOPT_GCC5/X64/SecurityPkg/Library/SecureBootVariableLib/UnitTest/SecureBootVariableLibUnitTest/OUTPUT/AutoGen.gcda
INFO - Processing /__w/1/s/Build/SecurityPkg/HostTest/NOOPT_GCC5/X64/SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoogleTest/OUTPUT/SecureBootVariableLibGoogleTest.gcda
INFO - geninfo: WARNING: /usr/include/c++/14/ext/atomicity.h:52: unexecuted block on non-branch line with non-zero hit count.  Use "geninfo --rc geninfo_unexecuted_blocks=1 to set count to zero.
INFO - 	(use "geninfo --ignore-errors gcov,gcov ..." to suppress this warning)
INFO - geninfo: ERROR: mismatched end line for _ZNK20SetArgBufferActionP2ILm4EPhmE10gmock_Impl17gmock_PerformImplIFvPtP4GUIDPjPyPvEvSt5tupleIJS4_S6_S7_S8_S9_EES4_S6_S7_S8_S9_N7testing8internal12ExcessiveArgESF_SF_SF_SF_EET0_RKT1_RKT2_RKT3_RKT4_RKT5_RKT6_RKT7_RKT8_RKT9_RKT10_RKT11_ at /__w/1/s/UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h:47: 47 -> 55
INFO - 	(use "geninfo --ignore-errors mismatch ..." to bypass this error)
INFO - ------------------------------------------------
INFO - --------------Cmd Output Finished---------------
INFO - --------- Running Time (mm:ss): 00:01 ----------
INFO - ----------- Return Code: 0x00000001 ------------
INFO - ------------------------------------------------

This is a known problem. lcov 2.0 does more checks than previous versions and thus finds some
new things. This can be silenced with a command line switch.
See:

@osteffenrh osteffenrh marked this pull request as ready for review October 1, 2024 10:06
@tianocore-assign-reviewers
Copy link

⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:

Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

@osteffenrh
Copy link
Contributor Author

(Fixed copy-paste error in the image URL)

@osteffenrh osteffenrh changed the title [TEST] CI: test f40 image CI: test f40 image Oct 1, 2024
@osteffenrh osteffenrh changed the title CI: test f40 image CI: Use new Fedora-40 image for Linux jobs Oct 1, 2024
@osteffenrh osteffenrh mentioned this pull request Oct 2, 2024
Open
@osteffenrh
Copy link
Contributor Author

@spbrogan @YuweiChen1110 @lgao4 @BobCF @bcran ping?

@osteffenrh
Copy link
Contributor Author

Hm, that error is new after rebasing...

@lgao4
Copy link
Contributor

lgao4 commented Nov 11, 2024

Could you resolve CI failure first?

@osteffenrh osteffenrh marked this pull request as draft November 12, 2024 16:55
@osteffenrh osteffenrh closed this Nov 25, 2024
@osteffenrh osteffenrh reopened this Nov 26, 2024
@osteffenrh
Copy link
Contributor Author

Could you resolve CI failure first?

@lgao4, fixed the CI.

This image now includes libasan and libubsan, as requested by @mdkinney here tianocore/containers#103

@osteffenrh osteffenrh marked this pull request as ready for review November 26, 2024 11:55
@osteffenrh
Copy link
Contributor Author

@kraxel ^

@osteffenrh
CI: Use latest Fedora 40 image for Linux jobs
43b9c9b 
The Fedora 40 images uses gcc 14, includes libasan and
libubsan, clang, and some fixes and improvements.

See tianocore/containers@c98ff99

Signed-off-by: Oliver Steffen <[email protected]>
@osteffenrh
BaseTools: Coverage: make lcov v2.0 work
974bd8e 
lcov 2.0 and newer does additional error and consistency checking
compared to previous versions. This can lead to CI jobs failing due to
new/unexpected errors showing up.

See:
- https://edk2.groups.io/g/devel/message/116138
- linux-test-project/lcov#209
- linux-test-project/lcov#238

Signed-off-by: Oliver Steffen <[email protected]>
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Dec 4, 2024
@mergify mergify bot merged commit 61c7142 into tianocore:master Dec 4, 2024
126 checks passed
@osteffenrh osteffenrh deleted the ci-test-f40-image branch December 4, 2024 07:22
@mdkinney
Copy link
Member

mdkinney commented Dec 4, 2024 •
edited
Loading

@osteffenrh

The change to BaseTools works with the Fedora 40 container, but breaks local builds with lcov 1.x installed. It would be better if this change to BaseTools could detect the lcov version and add the extra flag only of lcov is 2.x.

@osteffenrh
Copy link
Contributor Author

@osteffenrh

The change to BaseTools works with the Fedora 40 container, but breaks local builds with lcov 1.x installed. It would be better if this change to BaseTools could detect the lcov version and add the extra flag only of lcov is 2.x.

Sorry about that - I'll add a version check.

@osteffenrh
Copy link
Contributor Author

@osteffenrh
The change to BaseTools works with the Fedora 40 container, but breaks local builds with lcov 1.x installed. It would be better if this change to BaseTools could detect the lcov version and add the extra flag only of lcov is 2.x.

Sorry about that - I'll add a version check.

#6507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexcran bexcran bexcran approved these changes

@gguo11837463 gguo11837463 gguo11837463 approved these changes

@Javagedes Javagedes Javagedes approved these changes

@mdkinney mdkinney mdkinney approved these changes

@kraxel kraxel kraxel approved these changes

@BobCF BobCF Awaiting requested review from BobCF

@lgao4 lgao4 Awaiting requested review from lgao4

@spbrogan spbrogan Awaiting requested review from spbrogan

@YuweiChen1110 YuweiChen1110 Awaiting requested review from YuweiChen1110

Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@osteffenrh @lgao4 @mdkinney @kraxel @Javagedes @gguo11837463 @bexcran