CI Test #6224
Draft
CI Test #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ajfish,
a user,
BobCF,
jyao1,
leiflindholm,
lgao4,
LiuZhiguang001,
liyi77,
mdkinney,
SaloniKasbekar,
YuweiChen1110 and
Zclarkwilliams
mikebeaton
force-pushed
the
restore
branch
4 times, most recently
from
8c5c95a
to
dadb611
Compare
|
PR can not be merged due to conflict. Please rebase and resubmit |
But there is currently no default scope for 'macOS and Linux, but not Windows'
Required in addition to 48a4264, to prevent further 'set but not used' errors when building RELEASE code on XCODE5. Signed-off-by: Mike Beaton <[email protected]>
Without this change we get: error: equality comparison with extraneous parentheses when building on XCODE5. Signed-off-by: Mike Beaton <[email protected]>
…ed. for architecture x86_64
mikebeaton
commented
Sep 28, 2024
| @@ -6,6 +6,6 @@ | |||
| ## | |||
| { | |||
| "id": "binwrappers", | |||
| "scope": "global-nix", | |||
| "scope": "global", | |||
There was a problem hiding this comment.
@Javagedes - This change is required for macOS stuart support (i.e. macOS requires the PosixLike files too). But obviously it's not correct to enable them for Windows, as I've done here. It might be useful to have a global Posix (maybe global-psx?) scope which is set on both macOS and Linux, but not on Windows, and which could then be used here. (Or can "scope" here be a list? If so, defining a new global-mac scope, and making the scope list here be "global-nix,global-mac" would also be a clean solution.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.