Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmulatorPkg WinThunk.c: Use Win32 API to Query PerformanceFrequency and PerformanceCount #6220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

EmulatorPkg WinThunk.c: Use Win32 API to Query PerformanceFrequency and PerformanceCount #6220

wants to merge 1 commit into from
+15 −4

Conversation

YangGangUEFI
Copy link
Contributor

Use Win32 API to Query PerformanceFrequency and PerformanceCount

Then we can use correct TimerLib in another code. Such as dpDynamicCommand(PerformanceLib).

These API are from profileapi.h header and can refer to https://learn.microsoft.com/en-us/windows/win32/api/profileapi/

Description

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Add dpDynamicCommand module into EmulatorPkg then run dp command in shell and compare the results without these changes.

Integration Instructions

N/A

@nate-desimone
Copy link
Member

@YangGangUEFI - Please check the CI build issues and make sure everything is green.

@YangGangUEFI
Copy link
Contributor Author

Hi @nate-desimone

Thanks for you reminder. Got the CI issue, I'll update the PR and make sure the CI check succeeds.

@YangGangUEFI YangGangUEFI force-pushed the emulatorpkg-winthunk-query-performance-x branch from 19e8051 to c6d856a Compare September 20, 2024 02:34
@YangGangUEFI YangGangUEFI marked this pull request as ready for review September 20, 2024 03:28
@YangGangUEFI
EmulatorPkg WinThunk: Use Win32 API to get Performance Frequency and …
3e40031 
…Count

Then we can use correct TimerLib in another code,
such as dpDynamicCommand(PerformanceLib).

These API are from profileapi.h header and can refer to the link:
https://learn.microsoft.com/en-us/windows/win32/api/profileapi/

Signed-off-by: Yang Gang <[email protected]>
@YangGangUEFI YangGangUEFI force-pushed the emulatorpkg-winthunk-query-performance-x branch from c6d856a to 3e40031 Compare September 20, 2024 03:28
@niruiyu niruiyu added the push Auto push patch series in PR if all checks pass label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niruiyu niruiyu niruiyu approved these changes

@ajfish ajfish Awaiting requested review from ajfish

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YangGangUEFI @nate-desimone @niruiyu