-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MdePkg: Define PI Specification Version Macro #6218
base: master
Are you sure you want to change the base?
Conversation
// PI Specification Version Information | ||
// | ||
#define PI_SPECIFICATION_MAJOR_REVISION 1 | ||
#define PI_SPECIFICATION_MINOR_REVISION 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the PEI, DXE, and MM table revisions to 1.80. Have all spec changes up to 1.80 been verified to be implemented in the edk2 repo? Please provide details on the list of features/changes that have been verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the items in PI 1.80 specification and their related commit in the edk2 repo:
-
2103 Adding EFI_DELAYED_DISPATCH_FUNCTION definition and explanation - f3b0ee0
-
2119 HOB Update for Memory Ranges Capable of Being Protected by CPU Cryptographic Capabilities - b538d6a
-
2147 EFI_RESOURCE_ATTRIBUTE_SP not defined in Resource Descriptor HOB - b538d6a
-
2160 MP Services 2 PPI Section - a430589
-
2161 Introduce unaccepted memory type - 6fd2d58
-
2340 Introduction of EFI_SW_EC_FRAGMENTED_MEMORY_MAP Status Code - e7667b7
-
2341 Introduction of EFI_PERIPHERAL_TPM Peripheral Subclass Definition - 7c703f0
-
2351 update PI spec revision Section - This PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some tables being updates from 1.6 to 1.8. Is this the full list of changes from 1.6 to 1.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdkinney The above comment lists the changes from 1.7B to 1.8. The rest are:
1.7:
- 1848 PEI Core PEIM Migration Support Change - 9bedaec
- 1856 SecCore/PeiCore BFV Requirement Change - 9b23c7b
- 1860 MM MP Protocol issues - 51dd408
- 1885 Add extended data for EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR - 2b005f4
- 1889 New Status Codes - f8683a4
- 1891 PEI delayed dispatch - 4ac2457
- 1892 new pi spec revision - 93ddc0d
- 1955 set (*Attributes) when EFI_PEI_GET_VARIABLE2 returns EFI_BUFFER_TOO_SMALL and Attributes is non-NULL - 91a33d4
- 1967 New architectural PPI for PI PEI Core FV Location - c93c0dc
- 1969 Incompatible Pci Ignore Option Rom - c477b27
1.7A:
- 1663 SmmSxDispatch2 to Register() is not clear - Documentation Update
- 1736 Specification of EFI_BOOT_SCRIPT_WIDTH in Save State Write - Documentation Update
- 1993 Allow MM CommBuffer to be passed as a VA - 9ad2b98
- 2017 EFI_RUNTIME_EVENT_ENTRY.Event should have type EFI_EVENT, not (EFI_EVENT*) - d342d31
- 2039 PI Configuration Tables Errata - Documentation Update
- 2040 EFI_SECTION_FREEFORM_SUBTYPE_GUID Errata - Documentation Update
- 2060 Add missing EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_PCI_ADDRESS definition - Already part of https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe
- 2063 Add Index to end of PI Spec - Documentation Update
- 2071 Extended cpu topology - 15ac284
1.7B:
- 2101 Fix DXE_SPECIFICATION_MINOR_REVISION and PEI_SERVICES_REVISION definitions - This PR
- 2110 Status Code Class definition, incorrect comment on OEM range - Documentation Update
- 2213 Clarify PEI Memory Allocation Rules - Documentation Update
- 2364 Inclusive language implementation - added new disclaimer section - Documentation Update
Defined PI specification version. Used them to define revisions of PEI/DXE/MM system tables. Cc: Felix Polyudov <[email protected]> Cc: Dhanaraj V <[email protected]> Cc: Liming Gao <[email protected]> Signed-off-by: Sachin Ganesh <[email protected]>
be8667b
to
5b120b3
Compare
Defined PI specification version.
Used them to define revisions of PEI/DXE/MM system tables.
Cc: Felix Polyudov [email protected]
Cc: Dhanaraj V [email protected]
Cc: Liming Gao [email protected]
Description
As defined in PI 1.8.A specification, created new macros to indicate PI Specification Version.
PEI, DXE and MM system table revisions will now be based on this main macro which will be updated for each PI Specification release.
How This Was Tested
N/A
Integration Instructions
N/A