Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkPkg/HttpBootDxe: Correctly uninstall HttpBootCallbackProtocol #6202

Merged
merged 2 commits into from
Sep 15, 2024
Merged

NetworkPkg/HttpBootDxe: Correctly uninstall HttpBootCallbackProtocol #6202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733d4aa
NetworkPkg/HttpBootDxe: Correctly uninstall HttpBootCallbackProtocol
mikebeaton Sep 13, 2024
c411076
Merge branch 'master' into httpbootcallback-uninstall
mergify[bot] Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions NetworkPkg/HttpBootDxe/HttpBootImpl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,19 @@ HttpBootUninstallCallback (
IN HTTP_BOOT_PRIVATE_DATA *Private
)
{
EFI_HANDLE ControllerHandle;

if (Private->HttpBootCallback == &Private->LoadFileCallback) {
if (!Private->UsingIpv6) {
ControllerHandle = Private->Ip4Nic->Controller;
} else {
ControllerHandle = Private->Ip6Nic->Controller;
}

gBS->UninstallProtocolInterface (
Private->Controller,
ControllerHandle,
&gEfiHttpBootCallbackProtocolGuid,
&Private->HttpBootCallback
Private->HttpBootCallback
);
Private->HttpBootCallback = NULL;
}
Expand Down
Loading