Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OvmfPkg: Use TdInfo instead of fw_cfg to get cpu count in TDVF #6133

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

sunceping
Copy link
Contributor

Currently TDVF gets cpu count information via fw_cfg, but this information can also be retrieved by calling of TdCall.TdInfo.

And TdCall is responded by tdx-module which is trust. So, from the security perspective we shall use TdCall.Tdinfo instead of fw_cfg.

Cc: Erdem Aktas [email protected]
Cc: Jiewen Yao [email protected]
Cc: Min Xu [email protected]
Cc: Gerd Hoffmann [email protected]
Cc: Elena Reshetova [email protected]
Signed-off-by: Ceping Sun [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@sunceping sunceping force-pushed the usetdinfocpucountforTdvf.v1 branch 2 times, most recently from 0a938fa to c3f57e6 Compare August 29, 2024 07:46
@sunceping sunceping marked this pull request as ready for review August 29, 2024 08:54
@sunceping sunceping force-pushed the usetdinfocpucountforTdvf.v1 branch 2 times, most recently from df7e754 to 5e476df Compare August 30, 2024 05:56
OvmfPkg/Library/PlatformInitLib/Platform.c Outdated Show resolved Hide resolved
OvmfPkg/Library/PlatformInitLib/Platform.c Show resolved Hide resolved
OvmfPkg/OvmfPkgIa32.dsc Show resolved Hide resolved
OvmfPkg/Library/PlatformInitLib/Platform.c Show resolved Hide resolved
Currently TDVF gets cpu count information via fw_cfg, but
this information can also be retrieved by calling of TdCall.TdInfo.

And TdCall is responded by tdx-module which is trust.
So, from the security perspective we shall use TdCall.Tdinfo instead
of fw_cfg.

Cc: Erdem Aktas <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Min Xu <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Elena Reshetova <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Sep 13, 2024
@mergify mergify bot merged commit ec18fa8 into tianocore:master Sep 13, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants