Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg DxeMain: Add late initialization for Debug Agent. #6032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Aug 1, 2024

Description

Add a late initialize in DxeMain for the debug agent. This is required for the debug agent to be able to setup events to handle image loads, exit boot services, and other important callbacks.

Define a reinitialize debug agent.

These are being used in https://github.com/microsoft/mu_feature_debugger

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

N/A

Integration Instructions

N/A

@github-actions github-actions bot requested a review from lgao4 August 1, 2024 23:52
cfernald and others added 2 commits September 19, 2024 12:16
Add a late initialize in DxeMain for the debug agent. This is required
for the debug agent to be able to setup events to handle image loads,
exit boot services, and other important callbacks.

Define a reinitialize debug agent.

Signed-off-by: Aaron Pop <[email protected]>
Handle both DEBUG_AGENT_INIT_REINITIALIZE and
DEBUG_AGENT_INIT_DXE_CORE_LATE InitFlags to prevent an assert.

No additional initlization takes place for these cases.

Signed-off-by: Aaron Pop <[email protected]>
@apop5
Copy link
Contributor Author

apop5 commented Sep 26, 2024

@lgao4

I've made the requested changes, can you please re-review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants