MdeModulePkg: Add alternative queue sizes in NVME driver #6024
+156
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivianNK
force-pushed
the
nvme_alt_queue
branch
from
23519a7
to
d55917d
Compare
mdkinney
reviewed
Aug 1, 2024
MdeModulePkg/MdeModulePkg.dec
Outdated
| @@ -1187,6 +1187,9 @@ | |||
| # @Prompt Delay access XHCI register after it issues HCRST (us) | |||
| gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000|UINT16|0x30001060 | |||
|
|
|||
| # Support alternative hardware queue sizes in NVME driver | |||
There was a problem hiding this comment.
Add @prompt and description of TRUE and FALSE setting and the default value.
Also, is this PCD really required? What would be the impact if just assuming this is always enabled. Prefer to not add new PCDs unless absolutely required.
Updates the `Cap` parameter for `ReadNvmeControllerCapabilities()` to be `OUT` since the buffer pointed to is written within the function. Signed-off-by: Michael Kubacki <[email protected]>
It has been observed that some faulty NVMe devices may return invalid values. The code in NvmExpressDxe recognizes the controller is not responding correctly and issues an ASSERT() often in DEBUG builds or a reset in RELEASE builds. The following changes are made to NvmeControllerInit() to prevent a faulty NVMe device from halting the overall boot: 1. Check the Vendor ID and Device ID to verify they are read properly and if not, return EFI_DEVICE_ERROR 2. After the ASSERT() when Memory Page Size Minimum (Cap.Mpsmin), produce an error message and return EFI_DEVICE_ERROR Signed-off-by: Michael Kubacki <[email protected]>
Add a new PCD that toggles between the old driver behavior and new behavior that uses a different hardcoded queue size to support specific devices. Default behavior should not change. Signed-off-by: Michael Kubacki <[email protected]> Signed-off-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
nvme_alt_queue
branch
from
d55917d
to
c419dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new PCD that toggles between the old driver behavior and new behavior that uses a different hardcoded queue size to support specific devices. Default behavior should not change.
MdeModulePkg/NvmExpressDxe: Improve NVMe controller init robustness
It has been observed that some faulty NVMe devices may return invalid values. The code in NvmExpressDxe recognizes the controller is not responding correctly and issues an ASSERT() often in DEBUG builds or a reset in RELEASE builds.
The following changes are made to NvmeControllerInit() to prevent a faulty NVMe device from halting the overall boot:
produce an error message and return EFI_DEVICE_ERROR
MdeModulePkg/NvmExpressDxe: Correct function parameter modifer
Updates the
Capparameter forReadNvmeControllerCapabilities()to beOUTsince the buffer pointed to is written within the function.Cherry-picked the following commits:
microsoft/mu_basecore@9837db3
microsoft/mu_basecore@0a5a1d9
microsoft/mu_basecore@e397168
How This Was Tested
Tested in Project MU
Integration Instructions
N/A