Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB #5732

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

SeWittSiemens
Copy link
Contributor

Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module.

Signed-of-by: Sebastian Witt [email protected]

Description

Calculation of first section in FileFindSection is wrong with FILE2 headers. This happens when the payload is bigger than 16MB.

  • Breaking change
  • Impacts security
  • Includes tests

How This Was Tested

Enable debug output.
In UefiPayloadPkg.fdf change:

DEFINE FD_SIZE = 0x01400000
DEFINE NUM_BLOCKS = 0x1400

Check if payload starts and successfully loads the DXE core.

Integration Instructions

N/A

@SeWittSiemens SeWittSiemens force-pushed the FixLoadDxeCore branch 3 times, most recently from 371a1a5 to 4aeae88 Compare June 6, 2024 09:37
@gguo11837463
Copy link
Contributor

gguo11837463 commented Jun 6, 2024

image
Please add below into PR.

Reviewed-by: Guo Dong <[email protected]>
Cc: Sean Rhodes <[email protected]>
Cc: James Lu <[email protected]>
Reviewed-by: Gua Guo <[email protected]>

Fix calculation of first section in FileFindSection for FILE2 headers
in UefiPayloadEntry module.

Signed-off-by: Sebastian Witt <[email protected]>
Reviewed-by: Guo Dong <[email protected]>
Cc: Sean Rhodes <[email protected]>
Cc: James Lu <[email protected]>
Reviewed-by: Gua Guo <[email protected]>
@SeWittSiemens
Copy link
Contributor Author

Done

@gguo11837463 gguo11837463 added the push Auto push patch series in PR if all checks pass label Jun 10, 2024
@mergify mergify bot merged commit 6d15276 into tianocore:master Jun 10, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants